-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error in BieglerKKTSystem's solve for nontrivial scaling #71
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #71 +/- ##
==========================================
- Coverage 76.76% 69.11% -7.65%
==========================================
Files 22 28 +6
Lines 2152 2409 +257
==========================================
+ Hits 1652 1665 +13
- Misses 500 744 +244 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. So ] test
now uses CUDA 12.1 for now.
Can we use CUDA 12.3 by default? |
I should mention that
|
Yes, we only support |
Right now, I prefer to keep CUDA runtime 11.8 as the default, as this is the one we are using for our benchmarks. We should be able to replace cusolverRF by CUDSS soon, but I don't know if CUDA 12.3 is available on polaris, which could be a problem for us. An alternative solution is to test both for CUDA 11.8 and 12.3 in Argos. But that could be addressed in a separate PR. |
cc @amontoison : that explains why we observed a large errors in the KKT benchmark.