Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nb.metadata.file_extension fixes when upstream PR merged #177

Closed
chrisjsewell opened this issue May 15, 2020 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@chrisjsewell
Copy link
Member

See jupyter/jupyter-sphinx#127

Then the upcoming changes in #175 and

MyST-NB/myst_nb/cache.py

Lines 185 to 191 in afba1fe

# This is a 'fix' for jupyter_sphinx, which requires this value for dumping the
# script file, to stop it from raising an exception if not found:
# Normally it would be added from the executed notebook but,
# since we are already logging an error, we don't want to block the whole build.
# So here we just add a dummy .txt extension
if "language_info" not in ntbk.metadata:
ntbk.metadata["language_info"] = nbf.from_dict({"file_extension": ".txt"})
can be removed

@chrisjsewell chrisjsewell added the enhancement New feature or request label May 15, 2020
@choldgraf
Copy link
Member

ah nice - if you get that patch in to jupyter-sphinx, I'll cut another patch release and then we can close the myst-nb PR I've got, I agree this is a better fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants