Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NB execution can fail on ReadTheDocs #217

Closed
mje-nz opened this issue Aug 4, 2020 · 14 comments · Fixed by #219
Closed

NB execution can fail on ReadTheDocs #217

mje-nz opened this issue Aug 4, 2020 · 14 comments · Fixed by #219
Labels
bug Something isn't working

Comments

@mje-nz
Copy link

mje-nz commented Aug 4, 2020

Describe the bug
All the matplotlib figures on https://myst-nb.readthedocs.io are not rendering, along with the examples of displaying pd.DataFrame and IPython.display.Math, and the whole "Widgets and interactive outputs" notebook.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://myst-nb.readthedocs.io/en/latest/use/glue.html, https://myst-nb.readthedocs.io/en/latest/examples/basic.html, or https://myst-nb.readthedocs.io/en/latest/examples/interactive.html.
  2. Observe the missing outputs.
@mje-nz mje-nz added the bug Something isn't working label Aug 4, 2020
@welcome
Copy link

welcome bot commented Aug 4, 2020

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@chrisjsewell chrisjsewell linked a pull request Aug 4, 2020 that will close this issue
@chrisjsewell
Copy link
Member

thanks @mje-nz, yes indeed some notebook executions are failing on RTD: https://readthedocs.org/projects/myst-nb/builds/11469995/
I've opened a PR above to look into fixing this #218

@chrisjsewell
Copy link
Member

This may be part of the problem (https://github.com/executablebooks/MyST-NB/pull/218/checks?check_run_id=944445317):

----------------------------- Captured stdout call -----------------------------
## deleted test_complex_outputs_unrun.ipynb/cells/0/outputs/0:
-  output:
-    output_type: stream
-    name: stderr
-    text:
-      Matplotlib is building the font cache; this may take a moment.

@choldgraf
Copy link
Member

done! also what's your RTD handle? I tried chrisjsewell but it said that didn't exist

@chrisjsewell
Copy link
Member

chrisjsewell commented Aug 4, 2020

done! also what's your RTD handle? I tried chrisjsewell but it said that didn't exist

I'm there as cjsewell, but it doesn't matter about me, the bot is our new ruler (when you have time, add him to all the EBP projects)

@chrisjsewell
Copy link
Member

FYI I enabled some versions on RTD: The plots are there in https://myst-nb.readthedocs.io/en/v0.8.3/use/hiding.html but missing in https://myst-nb.readthedocs.io/en/v0.8.4/use/hiding.html

@choldgraf
Copy link
Member

huh this is really weird, I haven't noticed any plots missing in the jupyter book docs, which I believe use the latest myst-nb? https://jupyterbook.org/interactive/hiding.html#hide-cell-inputs

@chrisjsewell
Copy link
Member

I'm just updating jupyter-cache first (to use nbclient), then I'll give it another try

@chrisjsewell chrisjsewell linked a pull request Aug 5, 2020 that will close this issue
@chrisjsewell
Copy link
Member

Err, I solved the main bug afeb1b0, but there is still this RTD specific problem: jupyter/nbclient#95

@chrisjsewell chrisjsewell reopened this Aug 5, 2020
@choldgraf
Copy link
Member

That's pretty weird... I wonder why rtd is behaving differently from the other ci/cd envs. Maybe a dependency they pre install or something?

@chrisjsewell
Copy link
Member

Think I've found the difference: readthedocs/readthedocs.org#7360

@chrisjsewell
Copy link
Member

This is now fixed for our documentation 🎉
Apparently RTD was using a "larger" builder for the PR build (see readthedocs/readthedocs.org#7360).
I'm getting clarification on what the specs are for small/large builders to feed back to jupyter/nbclient#95) and if its an issue they could/should be handling.
Otherwise, I guess it might be good to document this potential issue for other RTD users.

@chrisjsewell chrisjsewell changed the title Rich outputs missing on ReadTheDocs NB execution can fail on ReadTheDocs Aug 11, 2020
@chrisjsewell
Copy link
Member

This should also help jupyter/nbclient#101, but will have to wait until 0.4.3 is released

@chrisjsewell
Copy link
Member

nbclient 0.5 should hopefully now stop this from happening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants