-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] convenience commands for testing against a local kernel #425
[REF] convenience commands for testing against a local kernel #425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good to me 👍 thanks for updating the documentation as well, agree it is much easier to run this locally and iterate more quickly
can you get the lint
test passing before merging though?
LGTM too! |
thanks, I suggest we rebase this after getting #424 in which resolves the |
@moorepants @choldgraf The lint issue is ongoing but being dealt with see #426 , it would be great to get this PR in ahead of Monday if possible :D |
@TimStewartJ, It would be great if you try out this PR. You can get some review practice in and help out @stevejpurves. I can also try this out too. |
Yep, tried it out and it looks good to me as well! Edit with more relevant information: I've messed around with both of the new HTML files and I agree that it allows for a much cleaner quick development environment. Appending and removing The new package scripts are a nice touch and well appreciated as well. I've tried them out and they work great. |
This one is now green ✅ on the lint stage too. |
Problems this addresses:
This PR aims to make it easier to chose to test against a local kernel without needing to change the code and improve discoverability.
Changes
development.html
to a folder and split tolocal.html
andbinder.html
to cover the two casesnpm run develop
command works as beforenpm run develop:local
command to bring up the local page