Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-exercises, ensure-stubs-compile: Make them run in the travis weekly (they currently don't) #758

Closed
petertseng opened this issue Nov 20, 2018 · 1 comment

Comments

@petertseng
Copy link
Member

We build the master branch in Travis to make sure everything is good.

We'd like that to test every exercise. This was the approach agreed upon in #591 (comment) .

I present the most recent build of master, https://travis-ci.org/exercism/rust/jobs/455623555, where it says "No exercise was modified. The script is aborted."

Further, I present a build where I forced every exercise to be checked https://travis-ci.org/exercism/rust/jobs/456251504 for PR #727

Note the errors

hexadecimal's stub does not compile; please make it compile or remove all non-commented lines
nucleotide-codons's stub does not compile; please make it compile or remove all non-commented lines
Exercises that don't compile:
hexadecimal
nucleotide-codons

These two pieces together tell us that Travis CI's master build does not check exercises. As noted above, it should.


the below information is irrelevant for this issue:

We build the master branch weekly instead of on every push to master, because exercism/discussions#174 (comment) turned them off.
However, we do have the power to turn them back on if we so choose.
However, I think this detail is irrelevant to the issue at hand. No matter the mechanism of building master, it is currently the case that building master means no exercise is checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant