-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exercises do not provide a named file for the code to be delivered #137
Comments
It doesn't necessarily matter what the class file is named. If the user wants the class file named to match the class used by the tests, then this is easy enough to deduce from the tests. I'm not necessarily against having an empty class file for the user. But, it seems like a bunch of unnecessary work to me. |
I was under the impression that exercism required a particular file name for recognizing submissions. Is that not the case? |
Not to my knowledge. The exercism command line takes the filename as a param.
|
You're right, I'm wrong, it just depends on the provided root directory name for the exercise. So this is just a matter of convenience for the end user. (If the Rust track doesn't provide a file, it should! :D ) |
Part of the fun can be to figure out the types and signatures. |
Well, the way the Elm track does it, is by only providing an empty implementation file (albeit with a module definition on top). As @abo64 said, people should be able to figure out the types and signatures themselves, unless we want to guide them towards taking a specific path of course. So what about having empty files? Or maybe even better, use the object Bob {
def hey(statement: String): String = ???
} That way we can gradually ease users into learning Scala, and when the user has done a few exercises, we no longer provide a default implementation. |
Sounds good to me, @ErikSchierboom |
That seems like a very good idea! The ecmascript track also added some comments to the code: //
// This is only a SKELETON file for the 'Bob' exercise. It's been provided as a
// convenience to get you started writing code faster.
//
class Bob {
hey(message) {
//
// YOUR CODE GOES HERE
//
}
}
export default Bob; I wonder if we should do both. Do people always read the README fully? Sometimes I don't, and I just look at the tests. |
Yeah, why not. |
I am away bit skeptic about that 😀 I think we should only add the comments in code in the first exercise. Then the next couple of exercises could have only a stub implementation file. |
I'm pretty sure most people don't read the README at first @abo64, but maybe they do after suffering for a while. 😁 At first we used comments @ErikSchierboom, but the users - surprisingly - where not removing them before submitting. It was so frequent that started to be annoying to review the solutions. I really don't understand people... |
Hmmm, I think @rbasso has a point. The ecmascript track also has comments in the code, and a quick sample showed that around half of the people still had the comments in their code when they submitted. Perhaps we should then not put the comments in code, but only provide the stub implementation. |
…d Allergies.scala to src dir - refs exercism#137. Add topics to config.json - refs exercism#125
…tbash.scala - refs exercism#137. Add topics to config.json - refs exercism#125
… Add CryptoSquare.scala - refs exercism#137. Add topics to config.json - refs exercism#125
…ueens.scala - refs exercism#137. Add topics to config.json - refs exercism#125
…d Raindrops.scala - refs exercism#137. Add topics to config.json - refs exercism#125
Add file with expected interface. Refs #137
Add file with expected interface. Refs #137
Add file with expected interface. Refs #137
Add file with expected interface. Refs #137
Add file with expected interface. Refs #137
Add file with expected interface. Refs #137
Add file with expected interface. Refs #137
Should we close this issue? |
I think we can be relaxed here and just keep the ones past the first ten. |
Agreed |
In other tracks, there is a file that people can use to write their code (whether
bob.el
orbob.rb
orbob.ex
). In the Scala track, currently, that file does not exist, so we have to guess what the file name is supposed to be.This issue tracks the exercises that still need to be updated. No checkmark means the exercise still needs to be updated.
The text was updated successfully, but these errors were encountered: