Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spacy.set_factory is not defined in V2 #1357

Closed
christian-storm opened this issue Sep 23, 2017 · 3 comments
Closed

spacy.set_factory is not defined in V2 #1357

christian-storm opened this issue Sep 23, 2017 · 3 comments
Labels
bug Bugs and behaviour differing from documentation 🌙 nightly Discussion and contributions related to nightly builds

Comments

@christian-storm
Copy link

In researching/writing a response to #1105 I was trying to get factory components working but haven't been able to. To that end I don't see any mention of set_factory in the code base. Has it be implemented yet?

Your Environment

  • spaCy version: 2.0.0a13
  • Platform: Darwin-16.7.0-x86_64-i386-64bit
  • Python version: 3.6.0
  • Models: en, en_core_web_sm
@honnibal honnibal added the bug Bugs and behaviour differing from documentation label Sep 24, 2017
@honnibal
Copy link
Member

I'm still not thrilled about the factory stuff.

Maybe we should just accept having pipeline-specific load() functions? Then we could move the pipeline assembly out of the Language.__init__ altogether.

@ines ines added the 🌙 nightly Discussion and contributions related to nightly builds label Sep 27, 2017
@honnibal
Copy link
Member

honnibal commented Oct 9, 2017

See #1396

@honnibal honnibal closed this as completed Oct 9, 2017
@lock
Copy link

lock bot commented May 8, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bugs and behaviour differing from documentation 🌙 nightly Discussion and contributions related to nightly builds
Projects
None yet
Development

No branches or pull requests

3 participants