Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong token #744

Closed
CnsAd opened this issue Jan 16, 2017 · 3 comments
Closed

wrong token #744

CnsAd opened this issue Jan 16, 2017 · 3 comments
Labels
lang / en English language data and models

Comments

@CnsAd
Copy link

CnsAd commented Jan 16, 2017

INPUT:

import spacy
nlp = spacy.load('en')
doc1 = nlp(u"They have killed the bat last night. We were so scared!")
for token in doc1:
    print(token)

OUTPUT:
They
have
killed
the
bat
last
night
.
We
we
re
so
scared
the "were" has been tokenized wrongly!

@keotic
Copy link

keotic commented Jan 16, 2017

Noticed that as well, currently spotted this bug only at "were"

@ines
Copy link
Member

ines commented Jan 16, 2017

Ah, this seems to be a mistake in the tokenizer exceptions. It's adding all contractions with and without apostrophes, but were and Were should obviously have been excluded (like it's currently done for well, hell, ill etc).

This is easy to fix – will do this now and add a regression test.

@ines ines added lang / en English language data and models performance labels Jan 16, 2017
@ines ines closed this as completed in 50878ef Jan 16, 2017
@lock
Copy link

lock bot commented May 9, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lang / en English language data and models
Projects
None yet
Development

No branches or pull requests

3 participants