Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lemmatization of won't #948

Closed
chrisjbryant opened this issue Apr 2, 2017 · 3 comments
Closed

Lemmatization of won't #948

chrisjbryant opened this issue Apr 2, 2017 · 3 comments

Comments

@chrisjbryant
Copy link

chrisjbryant commented Apr 2, 2017

can't and won't get tokenized as ca n't and wo n't respectively.
In previous versions of spacy, the lemma of ca and wo was ca and wo.
Sicne the recent update, ca now is correctly lemmatized as can, but wo is still wo when it should be will.

Edit:
Also just noticed the lemma of sha in sha n't is not converted to shall.

Your Environment

  • spaCy version: 1.7.3
  • Platform: Linux-4.8.0-34-generic-x86_64-with-Ubuntu-16.04-xenial
  • Installed models: en, en_core_web_md
  • Python version: 3.5.2
@honnibal
Copy link
Member

honnibal commented Apr 2, 2017

Thanks! Will fix.

@ines ines closed this as completed in 808cd6c Apr 3, 2017
@ines
Copy link
Member

ines commented Apr 3, 2017

Just fixed this on master and it should work now – the tokenizer exceptions for the contractions were missing a TAG, so the lemma was overwritten by the lemmatizer.

@lock
Copy link

lock bot commented May 9, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants