-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching on windows-latest Fails (v5) #61
Comments
Figured I'd go ahead and post an update since I decided to take a crack at a solution myself. My proof-of-concept fork seems to be working after updating to use @actions/cache package in place of the Cypress fork. There's a slight change in signature between the fork and the current version, but the functionality of this action remains the same. I've run into an issue which causes the action to fail when using a matrix due to some issues with concurrency. I've got a quick and dirty fix, but it's not scalable long-term. I'll continue working on this in my free time and keep you updated. If I get to a point where I feel like this is an appropriate solution, I'll go ahead and make a PR. Here's the link to my fork: https://github.com/mondash/expo-github-action |
Awesome, thanks for the report! It's a bit weird that it fails on |
Alright, as mentioned you should be able to use it already! You can use |
Description of the bug
Caching creation fails when using the windows-latest runner.
To Reproduce
expo-cache
to true.Expected behavior
The cache to be created successfully.
Actual behavior
Cache creation fails: see log below.
Additional context
Partial output of the action in our workflow demonstrating the error:
If I had to guess, this problem is due to using the (almost 1 year out of date) Cypress fork of the cache action. Looking at the README for this repo, I see that the fork was originally used because the official action didn't support caching for 3rd party actions. I think that it is now possible to use the official action to do this and in doing so will use the newer code in the official action which will resolve this issue.
If possible, I'd really appreciate it if you would consider updating to use the official cache action. Thanks for your hard work and your time!
The text was updated successfully, but these errors were encountered: