Migrate expo-apple-authentication to the new modules API #20600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsapeta
force-pushed
the
@tsapeta/migrate-apple-authentication
branch
from
30721a3
to
aca74dc
Compare
expo-bot
added
bot: passed checks
lukmccall
approved these changes
Jan 2, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Continuing the migration to Expo Modules API and adding support for Fabric
How
First I did the usual steps that we do in the migration process.
Previously the package was exporting one view for each button type and style (9 different components). I think it was too much and since Expo Modules API doesn't support defining multiple views in one module definition, I decided to make it simple and encapsulate everything in one view.
While testing, I noticed that bare-expo ignored expo-apple-authentication in autolinking and doesn't have required entitlement for Sign In with Apple, so I unignored it and added the entitlement.
Test Plan
Examples work as expected (also in Fabric). For the CI, you can take a look at
aca74dc(#20600)