[localization] Fix two specific platform issues for Android and Web #22003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsapeta
reviewed
Apr 6, 2023
Simek
reviewed
Apr 10, 2023
...ages/expo-localization/android/src/main/java/expo/modules/localization/LocalizationModule.kt
Show resolved
Hide resolved
aleqsio
changed the title
expo-bot
added
bot: passed checks
tsapeta
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes: #21414
I'm unable to replicate it since it can't really happen in production – Android doesn't let you set a locale without a country.
This should fix the pre-launch report.
Closes: #22009
On web we now use
resolvedOptionsinstead ofnavigator.languagesfor calendars.How
Test Plan
Tested in bare expo if it doesn't break for some weird reason.
Checklist
expo prebuild& EAS Build (eg: updated a module plugin).