Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DocumentPicker copy to cache on iOS #23102

Merged
merged 4 commits into from
Jun 26, 2023

Conversation

aleqsio
Copy link
Contributor

@aleqsio aleqsio commented Jun 26, 2023

Why

Current implementation incorrectly appended paths and resulted in

Error: File '...' isn't readable.

because of path

...%2540aleqsio%252FreadableDocumentPicker/287DF057-2173-4655-BC8D-06F634700C00...

instead of path

...%2540aleqsio%252Freadable/DocumentPicker/287DF057-2173-4655-BC8D-06F634700C00...

How

Test Plan

Checklist

@aleqsio aleqsio requested a review from tsapeta June 26, 2023 09:58
@aleqsio aleqsio requested a review from lukmccall as a code owner June 26, 2023 09:58
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jun 26, 2023
@aleqsio aleqsio force-pushed the @aleqsio/fix-document-picker-copy-to-cache branch from 12045cf to 07f396e Compare June 26, 2023 10:00
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jun 26, 2023
@tsapeta tsapeta merged commit 7c71f12 into main Jun 26, 2023
8 checks passed
@tsapeta tsapeta deleted the @aleqsio/fix-document-picker-copy-to-cache branch June 26, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants