Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[notifications][Android] Convert all exported modules to new API #24499

Merged
merged 7 commits into from
Sep 22, 2023
Merged

[notifications][Android] Convert all exported modules to new API #24499

merged 7 commits into from
Sep 22, 2023

Conversation

lukmccall
Copy link
Contributor

@lukmccall lukmccall commented Sep 18, 2023 •
edited
Loading

Why

Converts all exported modules to new API in expo-notifications.

Test Plan

  • bare-expo ✅
  • expo go ✅

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Sep 18, 2023
@lukmccall lukmccall force-pushed the @lukmccall/notifications/migrate-almost-all-exported-modules branch from f2aab02 to 4f7508e Compare September 19, 2023 10:54
@lukmccall lukmccall changed the title [notifications][Android] Convert almost all exported modules to new API [notifications][Android] Convert all exported modules to new API Sep 19, 2023
@lukmccall lukmccall marked this pull request as ready for review September 19, 2023 11:09
@lukmccall lukmccall force-pushed the @lukmccall/notifications/migrate-almost-all-exported-modules branch from 8e98f25 to 71dab48 Compare September 21, 2023 08:26
@lukmccall lukmccall force-pushed the @lukmccall/notifications/migrate-almost-all-exported-modules branch from 71dab48 to 48e8d66 Compare September 21, 2023 13:48
@lukmccall lukmccall merged commit 229dec0 into main Sep 22, 2023
1 check passed
@lukmccall lukmccall deleted the @lukmccall/notifications/migrate-almost-all-exported-modules branch September 22, 2023 08:11
@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:

Generated by ExpoBot 🤖 against 0891afc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsapeta tsapeta tsapeta approved these changes

@Kudo Kudo Awaiting requested review from Kudo

Assignees
No one assigned
Labels
bot: fingerprint changed bot: suggestions ExpoBot has some suggestions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukmccall @expo-bot @tsapeta