[fix][calendar] Fix iOS 17 permissions in current module #24545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
alanjhughes
changed the title
tsapeta
approved these changes
Sep 20, 2023
| @@ -4975,7 +4975,7 @@ SPEC CHECKSUMS: | |||
| EXUpdates: a910a0b964a12f9c7a6d673bad3c5eb70249fc5e | |||
| EXUpdatesInterface: 98f69982f4b429eb62a1d99259bc980038240f27 | |||
| FBAEMKit: af2972f39bb0f3f7c45998f435b007833c32ffb2 | |||
| FBAudienceNetwork: 4d6223a9a88a22e9dca8c9e6c1829a8745b86228 | |||
| FBAudienceNetwork: 03e273f66b70756be7d060927111af97b7641b06 | |||
There was a problem hiding this comment.
Yeah, that happened after a rebase but not sure where it's coming from 🤔
There was a problem hiding this comment.
updated in this commit already 94a58ec
we could confirm the 03e273f66b70756be7d060927111af97b7641b06 is correct one
Kudo
reviewed
Sep 21, 2023
lukmccall
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #24343
In case we want to hold off on the full expo modules migration #24282 until SDK 50 this addresses the iOS permissions error in the current module
How
Use the new method to request permissions if on iOS 17. Added new keys to the plist and updated the config plugin
Test Plan
bare-expo. Passes on iOS 16 and 17