-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If IOS is forced to dark mode, userInterfaceStyle prop doesnt override it. #236
Comments
@hani-q Are you able to replicate this with the out of box react ActionSheetIOS? We're just passing the prop through to them. Thanks. |
@bradbyte nop, this only happens with this library, if I passed |
And the wired thing is: If I open the just-installed This also happened in This might only happens in dev mode (with online metro bundler). I'm not sure this is a bundler bug in this package or the issue is on the react-native side. |
@david50407 So are you saying that in production the ActionSheet uses the correct style, but only when developing locally it has the issue? It could be an issue with caching... perhaps deleting the dependency from your node_modules and and then reinstalling, or running expo with Thank you! |
@bradbyte Yes, I faced this issue only in development mode, but after I clean cache, the problem still happens. btw, I'm using React Native without expo and yarn (I use npm instead), if this is also important information to you. |
Facing somewhat of a similar issue.
Is being displayed as light. |
I did some digging and found this works as expected when your view is wrapped in a Modal. I remember something like this effecting other native pickers... where the expo userInterfaceStyle was overriding the view but when you are in a modal it's a separate layer and isn't being "forced". |
This doesn't work in expo go regardless of whether the view is wrapped in a modal. What I did find is if you "force" the userInterfaceStyle in the app.json file. It should filter through to react-native-action-sheet |
in the above example IOS physical phone is forced to Dark Mode. But if sheet is opened with light interfaceStyle. it still opens as dark.
The text was updated successfully, but these errors were encountered: