Return all Cookies in a response - NOT JUST ONE #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please send this PR to Facebook so that it gets merged upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Jack Byrne
react-native only returns ONE cookie in HTTP responses. Unfortunately, the Cookie I need is not the lucky one. This PR is to return all Cookies in the Response header. If the Cookie already exists in the responseHeadersMap, it is replaced by the value returned in the HTTP Response
Test Plan
Dont have any because I could not get react-native to build locally after spending days on it
VERY FRUSTRATING
Related PRs
Release Notes
React Native is great to work with but this breaking change is making it impossible for us to use this framework. Pity!