up to 1.20 and Hold business error

[hesining]

I find that my own error information of method and function turned to string, and I can't use it conveniently. The go 1.20 has the new function 'errors.Join' and I think the expr code about recover can modify like this

func (vm *VM) Run(program *Program, env interface{}) (_ interface{}, err error) {
	defer func() {
		if r := recover(); r != nil {
			f := &file.Error{
				Location: program.Locations[vm.ip-1],
			}

			var ok bool
			if err, ok = r.(error); !ok {
				f.Message = fmt.Sprintf("%v", r)
				err = f.Bind(program.Source)
			} else {
				err = errors.Join(err, f.Bind(program.Source))
			}
		}
	}()
//...
}

How about up to 1.20 and use the new feature ?

[antonmedv]

Currently some users of Expr still use go1.13. We have unit tests there too.

One way to get your own errors back: save errors in env struct’s field.

[hesining]

Currently some users of Expr still use go1.13. We have unit tests there too.

One way to get your own errors back: save errors in env struct’s field.

Yes, It's a way. save it in env struct’s field instead of return it. The only problem is that users should change their writing habits.

[GeraldXv]

I also encountered a similar problem.

[antonmedv]

What about adding WrappedError fields to file.Error?

[hesining]

What about adding WrappedError fields to file.Error?

it's a good idea. I'll try it later.

[hesining]

#352
@antonmedv I try it , please check it.

[antonmedv]

Released!