Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red loading icon (has imgError class) appears even in Whatsapp web and or text editors #642

Closed
dwengs opened this issue Dec 28, 2020 · 18 comments

Comments

@dwengs
Copy link

dwengs commented Dec 28, 2020

Describe the bug
In whatsapp web or even ckeditor plugin on websites, for about a few days (12-25-2020 and today) there is a "red loading icon". This icon shows for a few seconds and dissapears. I managed to check inspector and found it has id="hzImgLoader" and class="imgError"

To Reproduce
Steps to reproduce the behavior:

  1. Go to Whatsapp web and or ckeditor plugin
  2. Type something like "Malzeme"
  3. See that red icon

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome 87
  • Extensions: Page Load time, Window Resizer, Page Ruler Redux, Awesome Screenshot, Adblock

It looks like it is trying to show some image even I'm not hovering.

Edit

Looks like it only happens when I press "Z" key while cursor is hovering "iframe" of ckeditor and / or whatsapp typing inputs.

@extesy
Copy link
Owner

extesy commented Dec 28, 2020

This is the same complaint as in #639 caused by the change in color scheme. It used to have a less noticeable color. Should be fixed soon.

@dwengs
Copy link
Author

dwengs commented Dec 28, 2020

I think the problem is the fact that this loading icon is appearing even if I'm NOT hovering something. I'm okay with the colors etc.

@KaKi87
Copy link

KaKi87 commented Dec 30, 2020

This red element also happens on Discord after clicking on a picture attachment.
Thanks

@GrosPoulet
Copy link
Collaborator

Hi @KaKi87
I did not manage to reproduce the issue on Discord, can you provide an url please ?

@KaKi87
Copy link

KaKi87 commented Dec 30, 2020

In any guild, open any picture, from any message, and see the red element appear at top left :

HoverZoomPlusDiscordBug

@KaKi87
Copy link

KaKi87 commented Jan 1, 2021

Actually, it also sometimes happen after sending messages and switching channels.

@brinkdinges
Copy link

Today was the second time this loading image ended up in a WordPress post of mine. I'm not a fan of this new spinner.

@Industry
Copy link

I experience this on WhatsApp too and some other websites. Had a hard time figuring out which of my plugins was causing it until seeing this thread. Another website where it's a problem is Pixlr.com

@Industry
Copy link

Also happening in Outlook Webmail screenshot.

@extesy
Copy link
Owner

extesy commented Jan 26, 2021

@GrosPoulet Maybe we should just remove the error spinner completely? The "in-progress" makes more sense but I don't see much use in the spinner after the image failed to load.

@KaKi87
Copy link

KaKi87 commented Jan 26, 2021

Agreed. Please rollback everything. It was really great until then. 🙂

@GrosPoulet
Copy link
Collaborator

Damned, everybody hates this poor little spinner 😭
To be honest, me too, but it's very useful for debugging.
So i added an option to hide all spinners (in screenshot: "Display image loader" option):

  • the green one : loading in progress
  • the red one : loading failed
  • the orange one (not pushed yet to github) : image skipped because user enabled options below "Display image loader".

image
If it's ok for you, i'll try to push this stuff this week.

@KaKi87
Copy link

KaKi87 commented Jan 26, 2021

Could you add an option to remove its color so it would become discreet again ? ^^

@GrosPoulet
Copy link
Collaborator

It won't be displayed at all if you uncheck the option : "Display image loader"
Note: it will be unchecked by default.

@KaKi87
Copy link

KaKi87 commented Jan 26, 2021

If I remember correctly, it used to only show up when the picture takes longer than usual to load. Right ?

@GrosPoulet
Copy link
Collaborator

Red spinner is displayed when an error occurred while loading image (if you open the console you'll see more details)

@extesy
Copy link
Owner

extesy commented Jan 26, 2021

@GrosPoulet Can you please make that option off by default? Most users are lazy enough to not search for it in the options menu but will still get annoyed by the spinner.

@Industry
Copy link

I second making it off by default given its main use is for debugging and less-than-helpful for most users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants