Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptation to upcoming changes in aiida transport plugins #2

Open
ezpzbz opened this issue Feb 8, 2021 · 2 comments
Open

Adaptation to upcoming changes in aiida transport plugins #2

ezpzbz opened this issue Feb 8, 2021 · 2 comments

Comments

@ezpzbz
Copy link
Owner

ezpzbz commented Feb 8, 2021

Currently, there is an open PR on aiida-core which is touching transport plugins. This plugin needs some modifications which are suggested by @giovannipizzi in here.
For now, I'm putting a limit on aiida-core version in this plugin until I apply the changes.

@giovannipizzi
Copy link

The PR has been merged.
Note that the limit should be <2.0 now and now <1.6 (1.6 still has the "old" code and does not include the PR)

@ltalirz
Copy link

ltalirz commented Jan 27, 2022

@pzarabadip
By the way, I notice that your transport plugin inherits from Transport.
Is that on purpose or would it perhaps make sense to inherit from SshTransport instead and just modify the parts that need to be modified?

That could reduce the maintenance burden on your side (possibly the same for the scheduler plugin).

As transports are now being developed that are significantly different from SSH, we may see some changes to the transport API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants