Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scene.animation.time is initialized to zero, which may have unexepected effect with time range not starting at zero #1354

Closed
Tracked by #1243
mwestphal opened this issue Apr 2, 2024 · 0 comments · Fixed by #1617
Closed
Tracked by #1243

scene.animation.time is initialized to zero, which may have unexepected effect with time range not starting at zero #1354

mwestphal opened this issue Apr 2, 2024 · 0 comments · Fixed by #1617
Labels
type:bug Something isn't working
Milestone
3.0.0

Comments

@mwestphal
Copy link
Contributor

Describe the bug
scene.animation.time is initialized to zero, which may have unexepected effect with time range not starting at zero

To Reproduce
Steps to reproduce the behavior:

  1. Open the file using f3d --dry-run negative_range_animated.e
  2. File is already half animated

Expected behavior
We should start at the beginning of the timerange of the animation

Additional context
It is a secondary effect of #434 , we cant initialize the time to NaN because cxxopts does not support it
@mwestphal mwestphal added this to the 3.0.0 milestone Apr 4, 2024
@mwestphal mwestphal added the type:bug Something isn't working label Apr 4, 2024
@mwestphal mwestphal mentioned this issue Jul 13, 2024
Open
23 tasks
@mwestphal mwestphal mentioned this issue Sep 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug Something isn't working
Projects
F3D
Status: Done
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Use std::optional for options mwestphal/f3d
1 participant
@mwestphal