Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support debugging 3.13 #291

Open
rchiodo opened this issue Oct 9, 2024 · 3 comments
Open

Support debugging 3.13 #291

rchiodo opened this issue Oct 9, 2024 · 3 comments

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Oct 9, 2024

There's been some changes in CPython, which seems to make Pydevd not able to debug:

python/cpython@33da0e8#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0

I didn't go much farther than that, so there might be other internals that would have to change.

@rchiodo
Copy link
Contributor Author

rchiodo commented Oct 9, 2024

@fabioz is this something you're actively working on? I didn't see any other issues on it. We'd like to ship debugpy with this working ASAP, so if you're not busy getting this to work, I can push that change back here when I'm done.

@fabioz
Copy link
Owner

fabioz commented Oct 9, 2024

Yeah, new versions always need work as the debugger needs to work around a bunch of internal things in CPython... I'm not sure when I'll be able to tackle this, so, if you'd like to give it a go that'd be nice (it'd be nice to have that other PR: #290 in first though).

As a note, I'd suggest you start from the pydevd code and then port to debugpy.

Reasons:

  1. It's easier to not have the additional debugpy layer when debugging (so when you run pytest it's just the test and the debugger, whereas in debugpy you always have an additional layer of indirection which makes it a bit more cumbersome to debug core things).
  2. The test suite tests more internal things which is handy for new python versions (possibly as you've seen debugpy does have scenarios not matching here, but the usual is the other way around).

@rchiodo
Copy link
Contributor Author

rchiodo commented Oct 9, 2024

(it'd be nice to have that other PR: #290 in first though)

I'd love to finish this but we're facing pressure to get something working ASAP. I'm about halfway done with your comments but we'll likely have to fix debugpy before I can go back to working on that PR :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants