Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensor integration checks #47

Open
3 tasks
oscgonfer opened this issue Jul 27, 2023 · 1 comment
Open
3 tasks

Sensor integration checks #47

oscgonfer opened this issue Jul 27, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation sensors Sensor integration

Comments

@oscgonfer
Copy link
Contributor

oscgonfer commented Jul 27, 2023

Given the "larger" amount of sensors we are integrating lately, we would like to have documentation of:

  • How to integrate a sensor
  • What to check when doing it
  • How to test it (both quick and long term)

We can discuss this here and further down the line document it in the docs so that other people can also do it.
Finally, given the big effort of the mux branch, we would like to document that so that the integration is a bit easier for other people to integrate sensors in the SC firmware.

This is also linked to the fact that we might have a longer supported sensors list and we should somewhat automatize these tests to avoid wasting time during the tests.

@oscgonfer oscgonfer mentioned this issue Jul 27, 2023
11 tasks
@oscgonfer oscgonfer added documentation Improvements or additions to documentation sensors Sensor integration labels Jul 27, 2023
@pral2a
Copy link
Member

pral2a commented Sep 7, 2023

Strategies on Production Testing

  1. Each sensor (and potentially components) to inherit a test class where particular validation functions are written directly in the main firmware. That way the hardware can perform a self validation, even while in normal operation mode.
  2. Use existing commands available on the shell (and potentially add new ones) and implement the test procedure on a python script that executes and validates the hardware remotely over serial. That will be part of smartcitizen-tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation sensors Sensor integration
Projects
None yet
Development

No branches or pull requests

2 participants