-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FsToolkit.ErrorHandling errors on 4.0.0-theta-015 #3259
Comments
Well I guess inlining everything in the file seems to work. I don't mind doing it but feels like a weird change to me. Feel free to close if this is by design. |
Thanks a lot for reporting @TheAngryByrd! Our goal is to make every code compilable with Fable 3 also compilable with Fable 4 as-is, so ideally we shouldn't need to introduce code changes only for Fable 4. Although I'm surprised about two things:
|
No I do not. I haven't tried, but looking again, I wonder if it's related to the |
Thanks to your link I could reproduce and found the issue: it's the Still, I'm not sure why this issue didn't happen before and why the line number in the error log is so off. Maybe it's because of the conditional compilation with |
I was on 3.7.1 previously. Perhaps that wasn't introduced yet? 🤷♂️ |
I'd have to build with 3.7.1 to see what's the code compiled, but I doubt it because resolving generics at compile time has been a feature since the beginning. In any case, I've sent a PR to try to fix the build, including potential problems with the SDK. Can you please check? demystifyfp/FsToolkit.ErrorHandling#196 |
Description
👋 I'm going thru the process of updating FsToolkit.ErrorHandling to F# 7 however, I'm getting this error when compiling and running the tests.
This code was working before, I'm not sure what changed. I tried inlining a few of the functions in the module but it didn't seem to change anything.
Any pointers would be helpful! Thanks :)
Repro code
PR of FsToolkit
To run build either
build.cmd
orbuild.bash
should initiate it.Expected and actual results
Please provide the expected and actual results.
Related information
dotnet fable --version
The text was updated successfully, but these errors were encountered: