Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global.json SDK version is 5.0.100, unsupported by Microsoft and Ionide #107

Closed
davedawkins opened this issue Jan 1, 2023 · 5 comments
Closed

Comments

@davedawkins
Copy link
Contributor

This is low priority (for my own needs), but Chet Husk raises the point:

ionide/ionide-vscode-fsharp#1813 (comment)

Mainly I'm interested how we decide what SDK is best for widely-used projects like this one - is it safe to jump right up to 7.* or should be pick the latest 6.* (despite MS's recommendations), or leave it at 5.* in case we break anything?

@davedawkins davedawkins changed the title SDK version is 5.0.100, unsupported by Microsoft and Ionide global.json SDK version is 5.0.100, unsupported by Microsoft and Ionide Jan 1, 2023
@MangelMaxime
Copy link
Member

I think using LTS is best probably.

For compiling DLL I guess that doesn't matter too much which SDK we use as long we don't change the target. However for project which are libraries and need Fable to compile the demo, sample 7.* is not safe because Fable 3 doesn't handle it correctly...

fable-compiler/Fable#3294

@davedawkins
Copy link
Contributor Author

Thank you. LTS is 6.0, and in the linked issue you recommend

{
    "sdk": {
        "version": "6.0.0",
        "rollForward": "latestMinor"
    }
}

I'll make a PR for this

@MangelMaxime
Copy link
Member

Thank you

@davedawkins
Copy link
Contributor Author

Sorry that I missed the edit needed for the YML

@MangelMaxime
Copy link
Member

No problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants