Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update assembly plugin to 3.1.0 #1021

Merged
merged 1 commit into from
May 15, 2018

Conversation

laurentgo
Copy link
Contributor

Update maven-assembly-plugin to 3.1.0 to fix several issues regarding
descriptor import and file permissions

Signed-off-by: Laurent Goujon [email protected]

Update maven-assembly-plugin to 3.1.0 to fix several issues regarding
descriptor import and file permissions

Signed-off-by: Laurent Goujon <[email protected]>
@codecov
Copy link

codecov bot commented May 14, 2018

Codecov Report

Merging #1021 into master will increase coverage by 0.03%.
The diff coverage is 75%.

@@             Coverage Diff              @@
##             master    #1021      +/-   ##
============================================
+ Coverage     51.82%   51.85%   +0.03%     
  Complexity     1367     1367              
============================================
  Files           147      147              
  Lines          7460     7457       -3     
  Branches       1132     1132              
============================================
+ Hits           3866     3867       +1     
+ Misses         3229     3225       -4     
  Partials        365      365
Impacted Files Coverage Δ Complexity Δ
...ig/handler/compose/DockerComposeConfigHandler.java 71.73% <ø> (ø) 17 <0> (ø) ⬇️
...ic8/maven/docker/config/AssemblyConfiguration.java 72.3% <ø> (ø) 14 <0> (ø) ⬇️
...er/assembly/DockerAssemblyConfigurationSource.java 45.78% <ø> (+2.1%) 17 <0> (ø) ⬇️
...abric8/maven/docker/config/ArchiveCompression.java 72.22% <ø> (ø) 8 <0> (ø) ⬇️
...o/fabric8/maven/docker/service/ArchiveService.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...a/io/fabric8/maven/docker/util/DockerFileUtil.java 75.6% <100%> (+0.6%) 11 <0> (ø) ⬇️
...8/maven/docker/assembly/DockerAssemblyManager.java 16.79% <50%> (ø) 11 <0> (ø) ⬇️

Copy link
Collaborator

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank ! Looks good and makes much sense.

@rhuss rhuss merged commit 8225540 into fabric8io:master May 15, 2018
@laurentgo laurentgo deleted the laurentgo/update-assembly-plugin branch May 15, 2018 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants