Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for CPU configurations with compose. #1102

Merged
merged 1 commit into from
Oct 3, 2018

Conversation

KristianAsp
Copy link
Contributor

Signed-off-by Kristian Aspevik [email protected]

@codecov
Copy link

codecov bot commented Oct 2, 2018

Codecov Report

Merging #1102 into master will increase coverage by 0.22%.
The diff coverage is 92.68%.

@@             Coverage Diff              @@
##             master    #1102      +/-   ##
============================================
+ Coverage     51.75%   51.97%   +0.22%     
- Complexity     1441     1457      +16     
============================================
  Files           150      150              
  Lines          7783     7821      +38     
  Branches       1160     1165       +5     
============================================
+ Hits           4028     4065      +37     
- Misses         3360     3361       +1     
  Partials        395      395
Impacted Files Coverage Δ Complexity Δ
...va/io/fabric8/maven/docker/service/RunService.java 51.7% <100%> (+0.62%) 25 <0> (ø) ⬇️
...g/handler/compose/DockerComposeServiceWrapper.java 61.57% <100%> (+2.81%) 62 <7> (+7) ⬆️
...aven/docker/config/handler/property/ConfigKey.java 100% <100%> (ø) 10 <0> (ø) ⬇️
...ic8/maven/docker/config/RunImageConfiguration.java 90.84% <100%> (+0.57%) 49 <3> (+3) ⬆️
...config/handler/property/PropertyConfigHandler.java 74.22% <100%> (+0.34%) 115 <0> (+3) ⬆️
...ig/handler/compose/DockerComposeConfigHandler.java 72.63% <100%> (+0.89%) 17 <0> (ø) ⬇️
...bric8/maven/docker/access/ContainerHostConfig.java 85% <100%> (+0.46%) 39 <3> (+3) ⬆️
.../docker/config/handler/property/ValueProvider.java 86.73% <40%> (-2.52%) 11 <0> (ø)

Copy link
Collaborator

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, lgtm !

@rhuss rhuss merged commit 8153a23 into fabric8io:master Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants