Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'readOnly' option to run configuration to mount container's roo… #1125

Merged
merged 4 commits into from
Dec 12, 2018

Conversation

bgutjahr
Copy link
Contributor

'docker run' provided the option --read-only to mount a container's root file system as read only.
The docker-maven-plugin didn't provide such an option, so I have added it to be able to run
integration tests with that option.

…t filesystem as read-only (like docker run --read-only)
@bgutjahr
Copy link
Contributor Author

bgutjahr commented Nov 22, 2018

Please let me know if the failed tests on CircleCI are caused by my changes, but to me it doesn't look so. All unit tests worked fine in my local build before I pushed my commit.

Copy link
Collaborator

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks good !

@rhuss rhuss merged commit ef2ba17 into fabric8io:master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants