Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1380 (including test) #1381

Merged
merged 2 commits into from
Sep 27, 2020
Merged

Fix #1380 (including test) #1381

merged 2 commits into from
Sep 27, 2020
+18 −5

Conversation

towtow
Copy link
Contributor

@towtow towtow commented Sep 22, 2020

See #1380

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 22, 2020 •
edited
Loading

Codecov Report

Merging #1381 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1381      +/-   ##
============================================
+ Coverage     57.63%   57.64%   +0.01%     
- Complexity     1910     1911       +1     
============================================
  Files           161      161              
  Lines          8993     8993              
  Branches       1355     1355              
============================================
+ Hits           5183     5184       +1     
  Misses         3336     3336              
+ Partials        474      473       -1
Impacted Files Coverage Δ Complexity Δ
.../fabric8/maven/docker/service/RegistryService.java 85.89% <ø> (+1.28%) 15.00 <0.00> (+1.00)

rhuss
rhuss approved these changes Sep 27, 2020
View reviewed changes
Copy link
Collaborator

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

Looks good to me

@rhuss rhuss merged commit 878e715 into fabric8io:master Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhuss rhuss rhuss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@towtow @rhuss