Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait http without redirect #499

Closed
Albatarm opened this issue Jun 28, 2016 · 6 comments
Closed

wait http without redirect #499

Albatarm opened this issue Jun 28, 2016 · 6 comments

Comments

@Albatarm
Copy link
Contributor

Hi,

It is possible to disable redirects on the http waiter for docker start goal ?
I would like to test that my image redirect correctly. But currently the wait fail because it try to get the redirected URL.

@rhuss
Copy link
Collaborator

rhuss commented Jun 28, 2016

That's currently not possible, sorry. However, it shouldn't be hard to implement. Fancy doing a PR ?
This would be the entry point.

@Albatarm
Copy link
Contributor Author

Pull request #500

@rhuss
Copy link
Collaborator

rhuss commented Jun 29, 2016

Thanks for the PR :). The question is, whether we want to have it configurable or not ? I'm not sure about a use case where waiting for a redirected URL to succeed makes sense, so whether it is worth to introduce such a config option.

wdyt ?

@Albatarm
Copy link
Contributor Author

I agree. We basically want to make sure the application is responding and is correctly initialized. Waiting for the URL given by redirection makes no sens.

@Albatarm
Copy link
Contributor Author

We could introduce a config option when needed

@rhuss
Copy link
Collaborator

rhuss commented Jun 29, 2016

I think we can live without. I will take this over for the next release.

Thanks !

@rhuss rhuss closed this as completed in 022aa4c Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants