-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify log message when waiting for URL #640
Conversation
The message now includes the default HTTP method and the default status code range
@rhuss lgtm |
ok to test |
thanks all, lgtm too |
okay lets merge it then [merge] |
oops, forgot the merge ;-) thanks @davsclaus .... |
Oh @rhuss just noticed it was merged into the |
The So by default I merge every PR into the However I'm open to align the workflow to the other fabric8 projects and maybe create a dedicated 'documentation' branch for the reference manual updates. This branch would then be rebased before eacht release. Or, as soon @kameshsampath contribution to our pipeline-library for re-creating the manual we could switch to that to only create documentation during a release build. |
Btw, this worklfow is also explained in https://github.com/fabric8io/docker-maven-plugin/blob/master/CONTRIBUTING.md:
|
@rhuss the pipeline doc is merged into lib, not able to test as our CD server is down |
awesome, will switch as soon as things stabilise ..... |
let us check once our CD server is up Monday ;) ?? |
hope so, but a lot of folks are already off for christmas holidays .... well, let' see ;-) |
The log message when waiting on a URL with default settings is a bit confusing:
WIth this change, the message now includes the default HTTP method and the default
status code range: