Don't fail build if volume-clean fails.

[KedneckInc]

This fix is admittedly simplistic. It does not take into account any of the other possible causes for an exception. However, if you are using volume-clean, chances are you're using volume-create, or many of the other goals provided by DMP. In that case, you will almost certainly receive errors pointing you at the
real problem.

[codecov]

Codecov Report

Merging #788 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #788      +/-   ##
============================================
- Coverage     50.98%   50.97%   -0.02%     
+ Complexity     1213     1212       -1     
============================================
  Files           140      140              
  Lines          7129     7129              
  Branches        956      956              
============================================
- Hits           3635     3634       -1     
  Misses         3178     3178              
- Partials        316      317       +1

Impacted Files	Coverage Δ	Complexity Δ
...ven/docker/access/hc/DockerAccessWithHcClient.java	14.04% <0%> (ø)	12 <0> (ø)	⬇️
...ain/java/io/fabric8/maven/docker/util/EnvUtil.java	66.21% <0%> (-0.68%)	42% <0%> (-1%)

[rhuss]

Sorry, for coming back to this PR that late. However, it seems to be broken to me when you look into the list of changes and touched files. The conflicts are because we moved on, but the original changeset is still too huge to even review it.

I'm going to close this PR therefore, it would be awesome if you create a new PR. Alternatively, if you describe the problem in a GitHub issue we could try to find a solution together.

Again sorry for the very late response.

[rhuss]

I cherry picked your change now, should be clean again.

[rhuss]

I just allowed 404 as a valid response code for a volume delete operation. This is returned when the volume does not exists. I think this is the better solution.

[KedneckInc]

Wunderbar! I'll give it a look because I finally got back to that part of the project!

[KedneckInc]

Sorry I took so long to get back to this. Yes, this definitely fixed the problem. Many Thanks! Now our developers don't have to manually clean up the old volumes!