Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning that results when providing new --chown COPY flag #884

Merged
merged 2 commits into from
Nov 4, 2017
Merged

Fix warning that results when providing new --chown COPY flag #884

merged 2 commits into from
Nov 4, 2017

Conversation

romank8k
Copy link
Contributor

This fixes logging an invalid warning that results when providing the new --chown flag to the COPY command in a custom Dockerfile.

@codecov
Copy link

codecov bot commented Oct 26, 2017

Codecov Report

Merging #884 into master will increase coverage by 0.13%.
The diff coverage is 58.33%.

@@             Coverage Diff              @@
##             master     #884      +/-   ##
============================================
+ Coverage     50.84%   50.98%   +0.13%     
- Complexity     1208     1213       +5     
============================================
  Files           140      140              
  Lines          7123     7129       +6     
  Branches        953      956       +3     
============================================
+ Hits           3622     3635      +13     
+ Misses         3189     3178      -11     
- Partials        312      316       +4
Impacted Files Coverage Δ Complexity Δ
...8/maven/docker/assembly/DockerAssemblyManager.java 17.62% <58.33%> (+5.01%) 11 <0> (+5) ⬆️

@romank8k
Copy link
Contributor Author

Forgot to mention, the --chown option is part of the release notes from 2017-09-26: https://docs.docker.com/release-notes/docker-ce/

@rhuss
Copy link
Collaborator

rhuss commented Oct 26, 2017

Thanks ! I hope I can review the PR soon ...

@rhuss
Copy link
Collaborator

rhuss commented Nov 4, 2017

Thanks ! I adapted a bit and the fix will be available in the version to be released on this weekend.

@rhuss rhuss merged commit f24e6ac into fabric8io:master Nov 4, 2017
@romank8k romank8k deleted the fix_verifyGivenDockerfile branch November 4, 2017 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants