Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Credentials helpers assumed to return a version number #896

Closed
giannello opened this issue Nov 8, 2017 · 2 comments
Closed

[BUG] Credentials helpers assumed to return a version number #896

giannello opened this issue Nov 8, 2017 · 2 comments

Comments

@giannello
Copy link
Contributor

Description

Starting with 0.23, docker-maven-plugin supports docker credential helpers. By default, they are called with the version argument to get the plugin version and use it in a log message.
Not all the helpers, however, return a version number when called with the version argument (tested with docker-credential-gcloud here, part of google-cloud-sdk).

Info

  • d-m-p version: 0.23.0
@giannello
Copy link
Contributor Author

@rhuss any chance to get the PR merged? This bug comes from a wrong assumption about the helpers' behavior, so it makes sense to make the version check optional.

@rhuss
Copy link
Collaborator

rhuss commented Jan 12, 2018

@giannello thanks for the PR, to make a PR integration sweep this weekend (constantly overloaded with 'regular' work at the moment). If I get to it, I will make a new release, too then.

thanks for your contribution ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants