Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiline labels and empty labels #968

Merged
merged 2 commits into from
Apr 4, 2018
Merged

support multiline labels and empty labels #968

merged 2 commits into from
Apr 4, 2018

Conversation

chonton
Copy link
Contributor

@chonton chonton commented Mar 10, 2018

section should be able to support multiline labels and empty labels

@codecov
Copy link

codecov bot commented Mar 10, 2018

Codecov Report

Merging #968 into master will increase coverage by 0.17%.
The diff coverage is 94.73%.

@@             Coverage Diff              @@
##             master     #968      +/-   ##
============================================
+ Coverage     51.57%   51.75%   +0.17%     
- Complexity     1232     1362     +130     
============================================
  Files           144      147       +3     
  Lines          7251     7462     +211     
  Branches        981     1132     +151     
============================================
+ Hits           3740     3862     +122     
- Misses         3195     3234      +39     
- Partials        316      366      +50
Impacted Files Coverage Δ Complexity Δ
...bric8/maven/docker/assembly/DockerFileBuilder.java 90.29% <94.73%> (+0.18%) 76 <5> (+4) ⬆️
...a/io/fabric8/maven/docker/config/UlimitConfig.java 71.42% <0%> (-19.05%) 9% <0%> (+1%)
...config/handler/property/PropertyConfigHandler.java 71.77% <0%> (-18.78%) 107% <0%> (+65%)
...a/io/fabric8/maven/docker/util/DockerFileUtil.java 63.82% <0%> (-11.18%) 11% <0%> (ø)
...ic8/maven/docker/config/AssemblyConfiguration.java 72.3% <0%> (-4.75%) 14% <0%> (ø)
...ven/docker/config/handler/ImageConfigResolver.java 96.29% <0%> (-3.71%) 10% <0%> (+2%)
.../fabric8/maven/docker/config/LogConfiguration.java 87.8% <0%> (-2.44%) 8% <0%> (ø)
...8/maven/docker/config/WatchImageConfiguration.java 60.86% <0%> (-1.04%) 1% <0%> (ø)
...fabric8/maven/docker/service/ContainerTracker.java 95.09% <0%> (-0.99%) 27% <0%> (ø)
.../fabric8/maven/docker/service/RegistryService.java 64% <0%> (-0.87%) 11% <0%> (ø)
... and 19 more

@rhuss
Copy link
Collaborator

rhuss commented Mar 12, 2018

Thanks ! I'm on the road currently but will have a look soonish.

@rhuss
Copy link
Collaborator

rhuss commented Apr 4, 2018

Thanks !

@rhuss rhuss merged commit 97e77d5 into fabric8io:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants