Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker:build to use a temporary directory inside the ${basedir}/target to avoid multi-project build issues #97

Closed
jstrachan opened this issue Feb 18, 2015 · 9 comments
Assignees
Labels
Milestone

Comments

@jstrachan
Copy link
Contributor

I've just hit an issue where a second docker image in a build got jars from a previous docker build :)

It seems like the temporary folder docker:build is using doesn't take into account the current ${basedir} from the project module.

It'd be good to make the default use ${basedir}/target/docker/... or something?

@jgangemi
Copy link
Collaborator

i thought $basedir was always assumed if the path is relative

@jstrachan
Copy link
Contributor Author

It doesn't seem to be in a multi-maven build; I can see the docker plugin using the exact output folder for every module ;)

@jgangemi
Copy link
Collaborator

yeah - i just noticed that myself but adding in $basedir where you suggested doesn't work but i have another idea.

@jgangemi jgangemi self-assigned this Feb 18, 2015
@jgangemi
Copy link
Collaborator

ok - i have a fix for this. let me put together a pull request.

@jstrachan
Copy link
Contributor Author

great thanks!

FWIW as a workaround I added this to my pom.xml:

        <docker.target.dir>${basedir}/target/docker-plugin</docker.target.dir>

https://github.com/fabric8io/quickstarts/blob/master/pom.xml#L79

which seems to be a work around

@jgangemi
Copy link
Collaborator

fixed - if you want to build a local copy, feel free to pull from my branch until @rhuss merges the changes in.

@jstrachan
Copy link
Contributor Author

thanks @jgangemi

@rhuss rhuss added this to the 0.11.2 milestone Mar 1, 2015
@rhuss
Copy link
Collaborator

rhuss commented Mar 1, 2015

fixed in 0.11.2

@rhuss rhuss closed this as completed Mar 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants