spring-boot-healthcheck adds probes to initContainers

[john-delivuk]

Description

With spring-boot-healthcheck enricher enabled, you'll get an invalid deployment spec because it will add livelinessProbes and readinessProbes to initContainers.

Info

• f-m-p version : 3.5.34

• Maven version (mvn -v) : 3.5.2

• Kubernetes / OpenShift setup and version :
  kubernetes 1.8.6

• If it's a bug, how to reproduce :
  Create a deployment with an init container and using springboot.

      initContainers:
      - command: "run.sh"
        image: someTaskThatRunsOnce:latest

[salaboy]

@john-delivuk are you testing with Spring Boot 2? I found some issues with it because now the health check endpoints are in a different path

[nicolaferraro]

There are 2 different issues:

1. This one is probably fixed by Improve support for sidecar containers #1202
2. Spring-boot 2 is not yet supported. Actuator endpoints for health check are different

[salaboy]

@nicolaferraro can you point me out to where I can update that one? it should be great to configure with something like this:

<enricher>
            <config>
              <spring-boot-health-check>
                <path>/actuator/health</path>
              </spring-boot-health-check>
            </config>
          </enricher>

I'm more than happy to send a PR if you give me some pointers.
I've just tested updating the deployment descriptor from /health to /actuator/health and it works. If you can point me to where I can add that enricher configuration I will submit a PR as a temporary fix.

[nicolaferraro]

@salaboy it would be awesome if you can work on a PR to change the plugin behavior according to the spring-boot version detected.

I've created issue #1206 to track (with info on how to implement it).

[rohanKanojia]

Marking this as duplicate of #1283, please revert if not understood right.

[rohanKanojia]

Duplicate of #1283

[stale]

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!