Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering of additional printer columns in the CRD #3153

Closed
lburgazzoli opened this issue May 20, 2021 · 4 comments
Closed

Ordering of additional printer columns in the CRD #3153

lburgazzoli opened this issue May 20, 2021 · 4 comments

Comments

@lburgazzoli
Copy link
Contributor

I noticed that the order for which the additionalPrinterColumns in the CRD definition is created sometimes changes which leads to different output and also to necessary changes to the files (which I check in into to the repository).

Would it be possible to either set an "order" field on the annotation or keep the ordering stable across builds ?

@lburgazzoli lburgazzoli changed the title Option to irder the additional printer columns Ordering of additional printer columns in the CRD May 20, 2021
@iocanel
Copy link
Member

iocanel commented May 20, 2021

I'm 5.4 they should be sorted by name.
If this is not enough we can introduce an order field in the annotation.

@metacosm
Copy link
Collaborator

I think the only thing that matters here is that the order is stable across builds, which it should now. This was addressed in #3071 (and subsequent fixes). Duplicates #3040.

@lburgazzoli
Copy link
Contributor Author

sorry I didn't notice there were an issue already

@metacosm
Copy link
Collaborator

No problems! I've been known to re-create tickets for issues I already created tickets for but forgot about… 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants