Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry setting should be applied when an IOException is thrown #3291

Closed
geoand opened this issue Jul 1, 2021 · 2 comments · Fixed by #3293
Closed

Retry setting should be applied when an IOException is thrown #3291

geoand opened this issue Jul 1, 2021 · 2 comments · Fixed by #3293
Labels
enhancement
Milestone
5.6.0

Comments

@geoand
Copy link
Contributor

geoand commented Jul 1, 2021

#3164 introduced support for retry setting when certain HTTP 5XX responses are received from the client in order to deal with transient failures.
In the same spirit, it makes sense to use the same settings to handle IOExceptions that can be thrown for example when an application tries to contact the API server via a sidecar that has not come up yet.
@geoand geoand mentioned this issue Jul 1, 2021
Merged
11 tasks
@attilapiros
Copy link
Contributor

Today I have a few hours at my computer and started to working on this.
Thanks @geoand for creating the issue!

@geoand
Copy link
Contributor Author

geoand commented Jul 2, 2021

Great, thanks 👌

@attilapiros attilapiros mentioned this issue Jul 2, 2021
Merged
11 tasks
@manusa manusa linked a pull request Jul 2, 2021 that will close this issue
Retry HTTP operation in case IOException too (exponential backoff) #3293
Merged
11 tasks
@manusa manusa added this to the 5.6.0 milestone Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
5.6.0
Development

Successfully merging a pull request may close this issue.

Retry HTTP operation in case IOException too (exponential backoff) attilapiros/kubernetes-client
3 participants
@manusa @attilapiros @geoand