deprecate KubernetesClient.customResource

[shawkins]

Given the support for genericKubernetesResources, customResources should now be deprecated.

[manusa]

I'm not sure I would fully agree on this one in case it refers to the class CustomResource and not the method KubernetesClient#customResources. (I recall having discussed this elsewhere, but I can't find the reference now.)

CustomResources are treated differently by Kubernetes and have specific areas of the API dedicated to them. They have specific validation, subresources, etc. which might not be shared by the rest of the K8s resources. Through the CustomResource class, we're also enforcing users to adopt best practices such as using Spec and Status fields.

Regarding the DSL method(s), they are already deprecated. We should update any documentation, example, quickstart, etc. to use the new methods and remove these methods in a future release after a prudent period.

[shawkins]

Regarding the DSL method(s), they are already deprecated. We should update any documentation, example, quickstart, etc. to use the new methods and remove these methods in a future release after a prudent period.

Sorry, I wasn't specific - KubernetesClient.customResource

kubernetes-client/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/KubernetesClient.java

Line 260 in 47efc3d

RawCustomResourceOperationsImpl customResource(CustomResourceDefinitionContext customResourceDefinition);

is not yet deprecated, it's what I'm referring to here.

[manusa]

There's a subtle difference with RawCustomResourceX and GenericKubernetesResource. I'm all in for deprecating, but I would wait for feedback before completely removing it.

[manusa]

Fixed by #3395