Different getPointer on version 3.2.0 and latest

[naonvl]

Hi, i have a code like this to override the getPointer

fabric.Canvas.prototype.getPointer = function (e, ignoreZoom) {
        if (this._absolutePointer && !ignoreZoom) {
            return this._absolutePointer;
        }
        if (this._pointer && ignoreZoom) {
            return this._pointer;
        }
        var simEvt;
        if (e.touches != undefined) {
            simEvt = new MouseEvent({
                touchstart: "mousedown",
                touchmove: "mousemove",
                touchend: "mouseup"
            }[e.type], {
                bubbles: true,
                cancelable: true,
                view: window,
                detail: 1,
                screenX: Math.round(e.changedTouches[0].screenX),
                screenY: Math.round(e.changedTouches[0].screenY),
                clientX: Math.round(e.changedTouches[0].clientX),
                clientY: Math.round(e.changedTouches[0].clientY),
                ctrlKey: false,
                altKey: false,
                shiftKey: false,
                metaKey: false,
                button: 0,
                relatedTarget: null
            });
            var pointer = fabric.util.getPointer(simEvt),
                bounds = upperCanvasEl.getBoundingClientRect(),
                boundsWidth = bounds.width || 0,
                boundsHeight = bounds.height || 0,
                cssScale;
        } else {
            var pointer = fabric.util.getPointer(e),
                bounds = upperCanvasEl.getBoundingClientRect(),
                boundsWidth = bounds.width || 0,
                boundsHeight = bounds.height || 0,
                cssScale;
        }
        if (!boundsWidth || !boundsHeight) {
            if ("top" in bounds && "bottom" in bounds) {
                boundsHeight = Math.abs(bounds.top - bounds.bottom);
            }
            if ("right" in bounds && "left" in bounds) {
                boundsWidth = Math.abs(bounds.right - bounds.left);
            }
        }
        this.calcOffset();
        pointer.x = Math.round(pointer.x) - this._offset.left;
        pointer.y = Math.round(pointer.y) - this._offset.top;
        /* BEGIN PATCH CODE */
        if (e.target !== this.upperCanvasEl) {
            var positionOnScene;
            if (window.innerWidth < 700) {
                positionOnScene = getPositionOnScene(raycastContainer, simEvt);
                if (positionOnScene) {
                    pointer.x = positionOnScene.x;
                    pointer.y = positionOnScene.y;
                }
            } else {
                positionOnScene = getPositionOnScene(raycastContainer, e);
                if (positionOnScene) {
                    pointer.x = positionOnScene.x;
                    pointer.y = positionOnScene.y;
                }
            }
        }
        /* END PATCH CODE */
        if (!ignoreZoom) {
            pointer = this.restorePointerVpt(pointer);
        }

        if (boundsWidth === 0 || boundsHeight === 0) {
            cssScale = { width: 1, height: 1 };
        } else {
            cssScale = {
                width: upperCanvasEl.width / boundsWidth,
                height: upperCanvasEl.height / boundsHeight,
            };
        }

        return {
            x: pointer.x * cssScale.width,
            y: pointer.y * cssScale.height,
        };
    };

The problem was that, this code runs perfectly on version 3.2.0 for both desktop and mobile. But once i upgrade the version to the latest, even to 3.3.0 the mobile version not working correctly.

[ShaMan123]

This is useful

                clientX: Math.round(e.changedTouches[0].clientX),
                clientY: Math.round(e.changedTouches[0].clientY),

You should PR

[naonvl]

yes, but when I'm using it on mobile it's not working if i'm using latest version of fabricjs, only works on 3.2.0 or older

[ShaMan123]

that is why I suggested to PR