Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying text does not dispatch object:modified event #2308

Closed
inssein opened this issue Jun 25, 2015 · 1 comment · Fixed by #2927
Closed

Modifying text does not dispatch object:modified event #2308

inssein opened this issue Jun 25, 2015 · 1 comment · Fixed by #2927

Comments

@inssein
Copy link
Contributor

inssein commented Jun 25, 2015

I just realized that the itext never dispatches an object:modified event when the text is altered. What would be an appropriate place to fix this?

Currently, I am thinking of putting it inside exitEditing() (itext_behavior.mixin.js). Any other suggestions?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@inssein
Copy link
Contributor Author

inssein commented Jun 25, 2015

Ah I just realized there is a text:changed event that fires every time there is a modification (insertChars(), removeChars()). Perhaps this could be switched to object:modified to maintain consistency?

Regardless, I think I am just going to bind to the editing:exited event and check if text has changed for my application, as the changed event is a too verbose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants