IText/Textbox - The first character is ignored when you type after selecting all text

[jafferhaider]

Steps for recreating:

1. Type some text into IText or Textbox
2. Use keyboard shortcut to select all (Cmd+A)
3. Type some more text. The first character that you type will not appear in the text. Text will start updating when the 2nd character is entered.

This is a recent issue, haven't come across it in the older builds. Any ideas @asturur?

[kangax]

We need to start adding functional tests where characters are being typed, removed, selected, etc.

Sent from my iPhone

On 28 Aug 2015, at 02:32, Jaffer Haider [email protected] wrote:

Steps for recreating:

1. Type some text into IText or Textbox
2. Use keyboard shortcut to select all (Cmd+A)
3. Type some more text. The first character that you type will not appear in the text. Text will start updating when the 2nd character is entered.

This is a recent issue, haven't come across it in the older builds. Any ideas @asturur?

—
Reply to this email directly or view it on GitHub.

[marcovdijk]

Couldn't this be related to #2448?

[FabianLauer]

I can confirm this:

[FabianLauer]

I don't have the time to write tests at the moment (thus no pull request), but I did find a few minutes to try something out. I think that replacing the onInput method in src/mixins/itext_key_behavior.mixin.js with this might solve the problem:

onInput: function(e) {
if (!this.isEditing || this._cancelOnInput) {
    this._cancelOnInput = false;
    return;
}
var offset = this.selectionStart || 0,
    textLength = this.text.length,
    newTextLength = this.hiddenTextarea.value.length,
    diff = newTextLength - textLength,
    charsToInsert;

if (this.selectionEnd !== 0 && this.selectionEnd !== this.selectionStart && this.selectionEnd === this.text.length) {
    charsToInsert = this.hiddenTextarea.value;
    this._removeCharsFromTo(this.selectionStart, this.selectionEnd);
} else {
    charsToInsert = this.hiddenTextarea.value.slice(offset, offset + diff);
}

this.insertChars(charsToInsert);
e.stopPropagation();
 }

Hope this is at least somewhat helpful.

[asturur]

found the error and solved. PR is coming.
It was a general error on deciding wich was the new text to add.

[FabianLauer]

Great news, just made my monday morning. Thanks 😄

[ykka]

This I think still happens on 1.6.0, or it has been fixed already?
thanks!

[asturur]

It has been fixed. There are some little problems with internet explorer 11 or edge.

[deepdoon]

It is still not working for IE 11. Any solution that can do the fix?
Thanks

[deepdoon]

@kangax @jafferhaider @asturur any update?? please

[schacki]

This is still not working with 1.6 and Chrome. Any update?

[asturur]

can you replicate the problem in a fiddle? to me it works.
Please tell us also operating system and keyboard type (latin, american, italian...)

[deepdoon]

@asturur It is not working in IE 11. I checked the same fiddle http://jsfiddle.net/kg9weds5/8/ . Double click to edit. Select all text type something you will see the bug.

[asturur]

i try today and investigate.

[deepdoon]

Thanks.

[schacki]

I was working with a RC version. After upgrading to 1.6.2 this has been fixed on Chrome

[deepdoon]

yea but problem still persists in IE.

[asturur]

ie11 or ie edge?

[deepdoon]

IE 11. haven't checked it on edge.

[butch2k]

Same issue with chrome btw.

[deepdoon]

for me it worked fine with chrome. I am using chrome Version 51.0.2704.103

[awehring]

I can confirm the bug for IE 11 (exactly: 11.0.9600.18349) for deepdoons jsfiddle..

[asturur]

guys fiddle runs on 1.6.0-rc1

[deepdoon]

Hi @asturur it is still not working for IE11 using 1.6.0-rc1 and 1.6.3. Steps that i followed for http://jsfiddle.net/kg9weds5/8/ are:

1. Open the link in IE11.
2. Double click the text object to get it into edit mode.
3. Select all text either by mouse or by pressing ctrl + A
4. Once text is selected type any letter lets say 'd'.
5. 'd' will not be displayed type another letter and that will get displayed.

So it is still skipping first letter in IE 11.

Thanks

[asturur]

ok i could replicate finally.
it does not get ignored. it leave one character from the old text instead of the one you pressed.

[lambdazen]

Ran into this problem with IE11. Here's a JSFiddle test case: http://jsfiddle.net/ewu2u5dr/1/