Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unselectable objects can be selected with Shift+click in specific cases (all browsers) #2460

Closed
nrossol opened this issue Sep 1, 2015 · 2 comments
Assignees
Labels

Comments

@nrossol
Copy link

nrossol commented Sep 1, 2015

First off: I love Fabric JS; it has made my current project a joy to implement! Thank you!

However, I have found a bug with group selections that can allow the selection of unselectable objects (i.e. objects with "selectable: false") through shift+clicks.

To recreate:
1: You can go to the fabric.JS customization demo (http://fabricjs.com/customization/) and scroll down to the "Unselectable object" demo.

2: Select at least 2 of the selectable (green) objects (i.e. so that they are both selected at the same time).

3: You can now use Shift+click to select the "unselectable" middle circle object and add it to the group selection.

Notes:
The bug seems to specifically require that 2 or more objects be selected in a group selection first. Selecting only one object, and then trying to add unselectable objects with Shift+click seems to not cause the bug to appear. The issue is consistent across Firefox, Chrome, and IE/edge.

@555ea
Copy link

555ea commented Sep 2, 2015

recreated, yep, that's true

@asturur
Copy link
Member

asturur commented Sep 2, 2015

reproduced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants