Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in createSVGFontFacesMarkup function - char is a reserved keyword #2934

Closed
haloween opened this issue May 3, 2016 · 1 comment · Fixed by #2935
Closed

Error in createSVGFontFacesMarkup function - char is a reserved keyword #2934

haloween opened this issue May 3, 2016 · 1 comment · Fixed by #2935

Comments

@haloween
Copy link

haloween commented May 3, 2016

Hello,

createSVGFontFacesMarkup uses a variable named "char", that's a reserved keyword and yui compressor in sencha touch doesn't allow to compress the app source.

var markup = '', fontList = { }, obj, fontFamily, style, row, rowIndex, char, charIndex, fontPaths = fabric.fontPaths;

The variable name should be changed to something that's not reserved.
http://www.w3schools.com/js/js_reserved.asp

Thanx

@asturur
Copy link
Member

asturur commented May 3, 2016

my bad for sure. i ll correct it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants