Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on change strokeWidth on the fly #3556

Closed
MatBdry opened this issue Dec 20, 2016 · 7 comments · Fixed by #3564
Closed

Issue on change strokeWidth on the fly #3556

MatBdry opened this issue Dec 20, 2016 · 7 comments · Fixed by #3564

Comments

@MatBdry
Copy link

MatBdry commented Dec 20, 2016

Version

1.7.2

Test Case

https://jsfiddle.net/jf03bbc3/7/

Steps to reproduce

select the rectangle

Expected Behavior

the strokeWidth must be added to the first element of the group and be visible

Actual Behavior

we do not see the strokeWidth until we resize the rectangle

Thanks !

@asturur
Copy link
Member

asturur commented Dec 20, 2016

http://fabricjs.com/fabric-object-caching

as soon as i will update this page with better descriptions for groups also, i ll point you there and close the issue.

Give it a read, your case is covered but not really explicitly.
I will update asap.

@MatBdry
Copy link
Author

MatBdry commented Dec 20, 2016

Ok ! Thank you so much

@asturur
Copy link
Member

asturur commented Dec 22, 2016

Ok i addressed the document, anyway the problem is weird and i think i will fix it.
As for now you do not any other thing to do rather than enabling statefullCache to true for the group, but i will fix it in 1.7.3

@asturur asturur closed this as completed Dec 22, 2016
@asturur asturur reopened this Dec 22, 2016
@MatBdry
Copy link
Author

MatBdry commented Dec 22, 2016

Yes I did it to solve my problem for the moment. I also noticed that I have much more blur on my objects on zoom in my canvas, even if I set noScaleCache to false.

@asturur
Copy link
Member

asturur commented Dec 22, 2016

that is strange. Can you post a fiddle? that may be image positioning that i notice less because i have a retina screen.

@asturur
Copy link
Member

asturur commented Dec 22, 2016

Got the error of the setting true.
I fixed it i push it now.
Please open a separate ticket for the blurriness, i would like to understand it.

@asturur
Copy link
Member

asturur commented Dec 22, 2016

1.7.3 won't be released soon, please check the fix and backport if needed.

https://github.com/kangax/fabric.js/pull/3564/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants