Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freehand drawing prevents drawing of point #4480

Closed
newtriks opened this issue Nov 20, 2017 · 1 comment · Fixed by #4492
Closed

Freehand drawing prevents drawing of point #4480

newtriks opened this issue Nov 20, 2017 · 1 comment · Fixed by #4492
Labels

Comments

@newtriks
Copy link

newtriks commented Nov 20, 2017

Version

2.0

Test Case

https://jsfiddle.net/q6hw8m3n/

Steps to reproduce

Configure canvas with drawingMode enabled. Click on the canvas.

Expected Behavior

A single point to have been drawn on the canvas.

Actual Behavior

A single point flickers briefly into view then disappears.

This actually worked in V1 https://jsfiddle.net/oz31LqLq/1/ so I'd suggest this as a regression. Funnily enough I have vague recollections of this being an issue at one point in a previous V1 build but cannot find a corresponding issue, but may have missed it?

@newtriks newtriks changed the title Freehand click with not drag shows then hides stroke Freehand drawing prevents drawing of point Nov 20, 2017
@asturur
Copy link
Member

asturur commented Nov 20, 2017

b1f0f67

i may have done something wrong in this commit.
I first fixed the point not being a point but an oval in a commit, then i went to fix the edges that were overlapping and i may have introduced a regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants