Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canvas.onBeforeScaleRotate not triggering while canvas is zoomed #4746

Closed
scriptspry opened this issue Feb 20, 2018 · 1 comment
Closed

canvas.onBeforeScaleRotate not triggering while canvas is zoomed #4746

scriptspry opened this issue Feb 20, 2018 · 1 comment

Comments

@scriptspry
Copy link
Contributor

Version

2.0.2

Test Case

http://jsbin.com/gunatuyusa/edit?html,js,output

Steps to reproduce

Try to scale, notice fill change.
Double click canvas, canvas is now zoomed.
Try to scale using bottom right corner, fill is not changed.

Expected Behavior

On canvas zoom, the callback should still be triggered

Actual Behavior

Callback not fired.


Narrowed down the issue to code:

src/mixins/canvas_events.mixin.js:576

      // determine if it's a drag or rotate case
      if (target._findTargetCorner(this.getPointer(e))) {
        this.onBeforeScaleRotate(target);
      }

It should be getPointer(e, true) ? I haven't tested it.
I do not have the development flow set up now. Will spend time when I have it.

@scriptspry
Copy link
Contributor Author

Tested working. Not sure if it is the right fix though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant