Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pencilBrush with rgba color problem since version 2.0.3 #4857

Closed
mmfouda opened this issue Mar 27, 2018 · 3 comments · Fixed by #4938
Closed

pencilBrush with rgba color problem since version 2.0.3 #4857

mmfouda opened this issue Mar 27, 2018 · 3 comments · Fixed by #4938
Labels
bug

Comments

@mmfouda
Copy link

mmfouda commented Mar 27, 2018

Version

2.0.3 and above

Test Case

https://jsfiddle.net/vvy24yd7/1/

Steps to reproduce

Revise the modifications done in ver. 2.0.3 on the pencilBrush.

Expected Behavior

The drawing should have real-time opacity.

Actual Behavior

The drawing have a solid color with some circles inside.
@asturur
Copy link
Member

asturur commented Mar 27, 2018

Yes, this is a problem of not having acceptance tests :(
i ll see if i can fix without reverting.

@asturur asturur added the bug label Mar 27, 2018
@asturur asturur mentioned this issue Apr 29, 2018
Merged
@asturur
Copy link
Member

asturur commented Apr 29, 2018

@mmfouda i started a fix and try to make it in a release this weekend.

@AndrewJDR AndrewJDR mentioned this issue May 4, 2018
Closed
@AndrewJDR
Copy link
Contributor

I've also noticed a performance issue caused by this same pencilbrush commit, details here - #4948

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Brush problems fabricjs/fabric.js
3 participants
@asturur @AndrewJDR @mmfouda