Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for stateful mixin method isEqual which fails hard on array value compared with null. #4950

Closed
keyurpatel opened this issue May 4, 2018 · 1 comment

Comments

@keyurpatel
Copy link
Member

keyurpatel commented May 4, 2018

Version

2.2.3

Test Case

http://jsfiddle.net/fabricjs/Da7SP/

Steps to reproduce

Description
stateful mixin method isEqual throw an exception when it tries to compare an array value with null.

Generally when we use stroke

  1. add an object
  2. apply stroke from line stroke to dashed stroke.

here when the state has changed for an object it verifies using isEqual mixin method and returns a boolean value. But while checking it fails where original array value is [4,1] and the current value is null and not an array.

Expected Behavior

it should return false

Actual Behavior

currently, throw an exception in the console.

Error stack reference
screen shot 2018-05-04 at 3 58 00 pm

@keyurpatel keyurpatel changed the title fix for stateful mixing method isEqual which fails hard on array value compared with null. fix for stateful mixin method isEqual which fails hard on array value compared with null. May 5, 2018
@asturur
Copy link
Member

asturur commented Jun 16, 2018

this has been fixed right?

@asturur asturur closed this as completed Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants